-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the "Select a language" design pattern #237
Comments
@sawyerh With this sort of thing, have we generally been preferring the |
@jcq We've been using the React USWDS components when possible, to reduce the amount of custom React components the template (and projects) then need to maintain themselves. |
OK, after spending some time working on this, I have a variety of questions, both about the Toggling between two languagesThe This is different than how it works on usa.gov (and how I would assume it would work). I could get around this while still using the Three or more languagesWhen it comes to the selection of language from three or more options, I have a question about the pattern from USWDS. They have the button text show the word "Language" in the currently set language. This means that if someone accidentally switches language (or perhaps clicks on a link somewhere with an alt locale set, or just does not recognize the word "Language" in the default locale) to something they don't understand, they might not have any idea which control can get them to the language they will understand. Unfortunately here we are limited by an adherence to USWDS patterns, but also by the fact that I don't know what would actually be better. This is where having an icon/graphic of some sort would likely be very helpful. I've read their guidance that eschews using flags (due to valid reasons), but we might want to consider this user experience. At a more technical level...The Would we still prefer to keep using |
I think the USA.gov approach is the correct approach, so
This is a good point. I lean towards sticking with USWDS out-of-box patterns, and leaving it to project teams to determine whether they want to deviate or not, since we don't know what a better approach is right now and won't be able to user test it.
This doesn't feel like a dealbreaker. I think your draft PR using the Next.js |
What's the task?
The template already supports internationalization (i.e. adding
/es-US
to the URL toggles to Spanish) but the template doesn't currently include an interface element for toggling the active language. There is some USWDS design pattern guidance we can follow for this: https://designsystem.digital.gov/patterns/select-a-language/The text was updated successfully, but these errors were encountered: