Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting/linting/ts check in E2E #813

Open
rylew1 opened this issue Dec 18, 2024 · 2 comments
Open

Add formatting/linting/ts check in E2E #813

rylew1 opened this issue Dec 18, 2024 · 2 comments

Comments

@rylew1
Copy link
Contributor

rylew1 commented Dec 18, 2024

Do we want formatting/linting and/or ts:check for writing E2E tests?

See https://github.com/navapbc/pfml-starter-kit-app/pull/229#discussion_r1889273383

Ex: We had no ts:check and had an extra await in code

@rylew1
Copy link
Contributor Author

rylew1 commented Feb 3, 2025

@lorenyu i think this needs to be done soon - kind of a pain to work with the growing e2e codebase without have prettier and linting

Do we want a google doc / design doc for this?

@lorenyu
Copy link
Contributor

lorenyu commented Feb 3, 2025

@rylew1 sounds good to prioritize this. A quick google doc / design doc sounds good. Should answer questions like how it gets set up for developers, when it runs, should it be part of CI and if so what workflow it should be a part of, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants