New pre-commit hook for autoflake

[hofbi]

Great collection of tools for notebooks. It would be great if you could add a pre-commit hook for https://github.com/PyCQA/autoflake

[MarcoGorelli]

Hey @hofbi

I'm not 100% confident about including autoflake, because imports might be used in parts of the notebook that nbqa can't currently process, see https://nbqa.readthedocs.io/en/latest/known-limitations.html

Having said that, you can already make a hook yourself to use autoflake:

- repo: https://github.com/nbQA-dev/nbQA
  rev: 1.5.2
  hooks:
    - id: nbqa
      entry: nbqa autoflake -i
      name: nbqa-autoflake
      alias: nbqa-autoflake
      additional_dependencies: [autoflake==<version number>]  # put which version of autoflake you want here

[hofbi]

Thanks @MarcoGorelli for the quick reply. I saw that it is possible to use custom tools. Would you be interested to add autoflake to your https://github.com/nbQA-dev/nbQA/blob/main/.pre-commit-hooks.yaml? I could come up with a PR. I just tried in on my notebooks and worked well so far.

[MarcoGorelli]

I'd rather not, sorry, just a bit concerned about imports that might be used in parts of the notebook that nbqa can't currently process, see https://nbqa.readthedocs.io/en/latest/known-limitations.html

It's one thing for flake8 to flag them, and there may be false positive, but I feel less easy about autoflake removing unused imports due to a known limitation in nbqa