Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve feedback on missing data flow #123

Closed
charphi opened this issue Jul 16, 2021 · 2 comments
Closed

Improve feedback on missing data flow #123

charphi opened this issue Jul 16, 2021 · 2 comments
Labels
enhancement New feature or request PROVIDER
Milestone
3.0.0-beta.3

Comments

@charphi
Copy link
Member

charphi commented Jul 16, 2021

On CLI, an invalid data flow reference generates a ResponseError: 404: null.
It would be better to check the reference before sending queries to server.
@charphi charphi added enhancement New feature or request CLI labels Jul 16, 2021
@charphi charphi added this to the 3.0.0-beta.3 milestone Jul 16, 2021
@charphi charphi changed the title Check data flow reference before sending requests Improve feedback on missing data flow Aug 11, 2021
@charphi
Copy link
Member Author

charphi commented Aug 11, 2021

A better solution (which involves less changes) is to catch ResponseError: 404: null and rethrow a better explanation.

@charphi charphi added PROVIDER and removed CLI labels Aug 11, 2021
@charphi
Copy link
Member Author

charphi commented Aug 11, 2021

Done in 5ca0235

@charphi charphi closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request PROVIDER
Projects
None yet
Milestone
3.0.0-beta.3
Development

No branches or pull requests
1 participant
@charphi