Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor features discovery #89

Closed
charphi opened this issue May 4, 2021 · 1 comment
Closed

Refactor features discovery #89

charphi opened this issue May 4, 2021 · 1 comment
Labels
API enhancement New feature or request
Milestone

Comments

@charphi
Copy link
Member

charphi commented May 4, 2021

Each provider have different capabilities and the current method SdmxConnection#isDetailSupported() is too limited to describe it. Another solution would be to use an enum instead.

For example:

enum SdmxWebFeature {
  KEY_FILTER,
  DETAIL_FILTER
}
@charphi charphi added the enhancement New feature or request label May 4, 2021
@charphi charphi added this to the 3.0.0-beta.3 milestone May 4, 2021
@charphi charphi added the API label May 4, 2021
@charphi charphi modified the milestones: 3.0.0-beta.3, 3.0.0-beta.4 Sep 13, 2021
@charphi charphi removed this from the 3.0.0-beta.4 milestone Oct 21, 2021
@charphi charphi added this to the 3.0.0-beta.6 milestone Feb 21, 2022
@charphi
Copy link
Member Author

charphi commented Feb 21, 2022

Done in 934412a

@charphi charphi closed this as completed Feb 21, 2022
@charphi charphi changed the title Replace SdmxConnection#isDetailSupported() with a more general solution Refactor features discovery Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant