Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5 support #17

Open
antoinemine opened this issue Jan 12, 2023 · 10 comments
Open

OCaml 5 support #17

antoinemine opened this issue Jan 12, 2023 · 10 comments

Comments

@antoinemine
Copy link

I see there have been some commits to help compiling under OCaml 5.

I've managed to compile master on OCaml 5.0.0 on the condition that profiling is disabled (it is enabled by default).
Should we disable profiling by default and do a new release and push to opam ?

Btw, I plan to make Apron compile under OCaml 5 and push a new opam version, which requires mlgmpidl, see antoinemine/apron#66

@nberth
Copy link
Owner

nberth commented Jan 12, 2023

Yes on the OCaml/C code side I think everything appears to be ready. The current issue is with integration in the opam repository: some changes are required by the repository maintainers in some conf-* packages, notably to use opam variables so as to offer cleaner support for new systems and architectures.

I've not had time to deal with that yet, so I'll try to get back to opam-repository maintainers and delay reworks on conf-* in the short term.

@nicokn
Copy link
Contributor

nicokn commented Mar 3, 2023

I've managed to compile master on OCaml 5.0.0 on the condition that profiling is disabled (it is enabled by default).
Should we disable profiling by default and do a new release and push to opam ?

Profiling is now, by default, disabled for all OCaml versions > 4.08.0 (PR #18)

@sim642
Copy link

sim642 commented Apr 1, 2023

The current issue is with integration in the opam repository: some changes are required by the repository maintainers in some conf-* packages, notably to use opam variables so as to offer cleaner support for new systems and architectures.

I've not had time to deal with that yet, so I'll try to get back to opam-repository maintainers and delay reworks on conf-* in the short term.

Is it described anywhere what these changes are and why they are blocking mlgmpidl's OCaml 5 support? I couldn't find any reference (e.g. open issue) about it.
It would be great to have an OCaml 5 compatible version released at least for the systems and architectures that are already supported. Support for new architectures sounds like a separate matter from OCaml 5.

@nberth
Copy link
Owner

nberth commented Apr 4, 2023

I finally managed to advance a bit on this front.
There's now a new version with tag 1.3.0 that should bring support for OCaml 5. Note the tag should still be considered temporary as I have probably some tweaks to tune that I'll discover using the opam CI. To do that last part I need ocaml/opam-repository#23613 to be merged first.

@antoinemine
Copy link
Author

I was wondering if there is any progress on having an opam release supporting OCaml 5.0 ?
I would like to make a new Apron release, with OCaml 5.0 support, and it seems that the lack of mlgmpidl opam package prevents this CI to work...

@nberth
Copy link
Owner

nberth commented Jul 7, 2023

I was wondering if there is any progress on having an opam release supporting OCaml 5.0 ? I would like to make a new Apron release, with OCaml 5.0 support, and it seems that the lack of mlgmpidl opam package prevents this CI to work...

Alas the PR I made on the opam repository to tune the related conf-* packages have been stale for some time (cf ocaml/opam-repository#23436). I think a quick temporary solution will be to first publish mlgmpidl on fewer architectures and systems until that issue is resolved.

@nberth
Copy link
Owner

nberth commented Jul 7, 2023

@antoinemine Hopefully ocaml/opam-repository#24078 will get through soon enough.

@nberth
Copy link
Owner

nberth commented Jul 11, 2023

@antoinemine ocaml/opam-repository#24078 is now merged, so you should be able to make a new release of Apron.

@nberth
Copy link
Owner

nberth commented Jul 11, 2023

I'll wait for some returns on actual uses of the library with OCaml 5.0 (some uses of Apron for instance) before closing this issue.

@sim642
Copy link

sim642 commented Sep 13, 2023

I can confirm that Apron v0.9.14~beta.2 with mlgmpidl 1.2.15 works in Goblint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants