Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Dependencies: Replace appcompat-v7 with support-fragment #91

Closed
commonsguy opened this issue Oct 3, 2017 · 2 comments
Closed

Reduce Dependencies: Replace appcompat-v7 with support-fragment #91

commonsguy opened this issue Oct 3, 2017 · 2 comments
Assignees
@ncapdevi

Comments

@commonsguy
Copy link

The frag-nav module declares a dependency on appcompat-v7, despite not using it. support-fragment should be sufficient to fulfill the imports, and that would make it simpler to use this library in an app that is not itself using appcompat-v7.

Thanks for considering this!
@ncapdevi
Copy link
Owner

ncapdevi commented Oct 3, 2017

@commonsguy You appear to be correct. Will pull that out in the next version (couple other things need fixed so it should be shortly). Thanks for pointing this out!

@ncapdevi ncapdevi self-assigned this Oct 3, 2017
@ncapdevi
Copy link
Owner

ncapdevi commented Oct 9, 2017

Fixed in 2.2.3

@ncapdevi ncapdevi closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncapdevi ncapdevi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@commonsguy @ncapdevi