-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CESM History File Parser Issue - CISM component #21
Comments
So it looks like the parser is using
The data starts with year 2, where for year 2 the The data appear to instantaneous as opposed to representative over some time period... would it be best to skip this then? It wouldn't have time bounds. |
It's my understanding the calendar units used here are also part of the problem (if you wanted to open the dataset with |
@mgrover1, is there any explanation as to why they use this reference instead of say |
So I tried manually changing the calendar units from
I am not sure why they do not use a cf-standard unit like days since or years since. Within the CESM-postprocessing repo @sherimickelson included a way of dealing with this when reading files in using the netcdf4 library. But this might be a model-output issue. |
@Katetc or @billsacks might be able help with input on this issue as it might be best to coordinate with them on the solution. |
I dug back into some emails from 2016, when this issue first arose. A number of us spent a HUGE amount of time on this 5 years ago, with many back and forths about what is and isn't acceptable, given what units are and aren't supported by various tools. There are a few separate but related issues here:
|
@billsacks, thank you for the clarification, and pointers!
I just submitted a PR upstream Unidata/cftime#246 that tries to address the issue @kmpaul opened. |
Awesome, thank you @andersy005 ! All: Please let us know if CISM's time units are causing any additional issues. |
@mgrover1, Unidata/cftime#246 got merged. This issue should be resolved in the next release of |
When the file parser attempts to read in the
CISM
component of CESM, the following error is returned when it reads in the file in xarrayUsing
decode_times = false
in xarray, where the time values are now a float n equal to "common_year since 0000-01-01 0:0:0"Would it make sense to add a try, except block, and allow the parser to feed "decode_times = false" in? I am wondering if this error would propagate downstream in the analysis...
The text was updated successfully, but these errors were encountered: