Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing tag's name doesn't work - problem with document and xml #38

Open
maayansharon10 opened this issue Feb 1, 2023 · 2 comments
Open

Comments

@maayansharon10
Copy link

maayansharon10 commented Feb 1, 2023

When changing tag's name, then going back to annotating, the tag inside the annotation page goes not change. Also, xml output doesn't change as well.

Steps to replicate issue :

  1. open a new project - uploaded one document and created an entity type name tag1
    image

  2. created an annotator, assigned to it the single document, and through their link - annotated the document
    image

  3. as the manager of the expiriement, download the xml output :

<source/>
<date/>
<key/>
<document>
<id>2302010902ZZD</id>
<infon key="tt_curatable">no</infon>
<infon key="tt_version">1</infon>
<infon key="tt_round">1</infon>
<passage>
<offset>0</offset>
<text>some sentence to annotate</text>
<annotation id="1">
<infon key="type">tag1</infon>
<infon key="identifier"/>
<infon key="annotator">annotator</infon>
<infon key="updated_at">2023-02-01T09:06:18Z</infon>
<location offset="6" length="10"/>
<text>entence to</text>
</annotation>
</passage>
</document>
</collection> 
  1. as manager, change the name of tag1 to tag2 by clicking on edit, change the name and save.

  2. as manager, go into the annotated document , now this is my view - sentence not marked as it is not marked as annotated with tag2
    image

  3. as annotator - I see this document like this -
    image

the xml output stays the same (was expecting it to change to tag2)

Appreciate the help a lot,
Thank you!

P.s - based on playing with the package, but not sure -
It seems to me that when editing an existing tag, let's call it tag1 it actually creates a new one, calling it tag2, and delete tag1, so that only tag2 exists, but the information that was nested with the tag1 is not duplicated into the tag2.
So actually now everything that was tagged under tag1 is still tagged with tag1, but tag1 does not exist anymore, so you can't see it in the ui. I guess it is saved somewhere in the backend so it appears at the xml output.

@dongseop
Copy link
Collaborator

dongseop commented Feb 4, 2023

Sorry. That is a known limitation for the current TeamTat.
Type names of annotations are simple text and they are not directly connected with entity types.
When you create an annotation, the system copies the text from the selected entity type and saves it.

Entity type was originally designed as a pre-defined dictionary for annotation jobs. We usually defined it before annotating. We didn't consider changing it.

I will discuss with other team members about this. Until then, please define entity types before annotation tasks.
Sorry for your inconvenience.

@maayansharon10
Copy link
Author

Thank you for explanation and the quick replay! I didn't realize that was the case.
Thanks again for the great package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants