Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add comment #145

Closed
DidierA opened this issue Sep 22, 2021 · 2 comments
Closed

Cannot add comment #145

DidierA opened this issue Sep 22, 2021 · 2 comments
Assignees
Labels

Comments

@DidierA
Copy link

DidierA commented Sep 22, 2021

Description:
I cannot add content in the 'Comment' column in Logger++. When I double click in the comment field of one line, it becomes editable, I can type my content, but cannot validate. If I press enter or click anywhere else, the field remains in edition mode, and the contents is not validated. The only way to get out is by pressing escape. A stackstrace is dumped on the error log when pressing enter, stating 'Data is read only'. I have attached the stacktrace.
loggerplusplus-stacktrace.txt

I don't know if it's relevant, but I also noticed that when Logger++ is active, the comment field in Logger (the one integrated to burp) is filled with entries starting with $LPP: such as $LPP:23:6663a343-49cb-4aa9-8ac8-05eef16c6ef5$

Steps To Reproduce:
Go to Logger++ Tab, click on the comment field on any line, enter contents and press enter.

Expected behavior:
The contents should be added to the comment column.

Screenshots:
image

Version:
3.19.2, updated august 6 in Bapp store <=> 3.18 here

@ngregoire
Copy link

ngregoire commented Sep 22, 2021

I confirm the bug. Note that the stack-trace appears in system logs, not in the Extender tab or in the Dashboard

@CoreyD97
Copy link
Contributor

CoreyD97 commented Apr 8, 2022

Sorry this took so long to get to, despite being such a simple fix.

The root cause here was switching to a different IHttpRequestResponse type, designed for persistent storage. This was done in the hopes to decrease memory usage, but seems to make the data read only.

I'll be pushing a new release for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants