Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CORAL to a modern version of jQuery #37

Open
remocrevo opened this issue Mar 25, 2015 · 6 comments
Open

Upgrade CORAL to a modern version of jQuery #37

remocrevo opened this issue Mar 25, 2015 · 6 comments

Comments

@remocrevo
Copy link
Contributor

We need to upgrade CORAL to use a newer version of jQuery, and we need a plan for staying up to date.

@PaulPoulain
Copy link
Contributor

Shouldn't we use the CDN instead of embeding jquery ?
Using
<script src="//code.jquery.com/jquery-VERSION.min.js"></script>
gives us a handy way to get the jquery version we want quickly.

We currently use the 1.4.4 it seems, we could have the following plan:

  • use the CDN for 1.4.4 and remove the old jquery
  • update to a newer version (and fix any problem)

Remington, if you agree with this proposal, I can do it (& do a pull request)

@remocrevo
Copy link
Contributor Author

@PaulPoulain yes, you are welcome to work on updating CORAL's version of jQuery. It looks like the calendar/date-picker is using an old custom plugin, so you should probably convert it to use whatever is normal in jQuery now. Thanks for offering!

@remocrevo
Copy link
Contributor Author

And yes, I think the CDN is probably fine. I can see possible benefits to including the jQuery code with CORAL so that each site hosts it themselves, but I don't know enough about it to make a recommendation.

@PaulPoulain
Copy link
Contributor

there's no real pro for hosting jquery yourself (that I know), and there are some cons:

  • Using CDN mean that your browser will load jquery once only for all the applications that use (this version) of jquery. Otherwise, each app load one. speed improvement.
  • Using CDN mean you get the fastest access you can imagine, because it's optimized for delivering this content.

@jeffnm
Copy link
Contributor

jeffnm commented May 13, 2015

I'm in favor of using a CDN.

@coraladmin
Copy link

That's three votes for CDN so it might as well proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants