-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CORAL to a modern version of jQuery #37
Comments
Shouldn't we use the CDN instead of embeding jquery ? We currently use the 1.4.4 it seems, we could have the following plan:
Remington, if you agree with this proposal, I can do it (& do a pull request) |
@PaulPoulain yes, you are welcome to work on updating CORAL's version of jQuery. It looks like the calendar/date-picker is using an old custom plugin, so you should probably convert it to use whatever is normal in jQuery now. Thanks for offering! |
And yes, I think the CDN is probably fine. I can see possible benefits to including the jQuery code with CORAL so that each site hosts it themselves, but I don't know enough about it to make a recommendation. |
there's no real pro for hosting jquery yourself (that I know), and there are some cons:
|
I'm in favor of using a CDN. |
That's three votes for CDN so it might as well proceed. |
We need to upgrade CORAL to use a newer version of jQuery, and we need a plan for staying up to date.
The text was updated successfully, but these errors were encountered: