Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobble check can miss tracks if the currently playing track is not scrobbled #21

Open
ndm13 opened this issue Jan 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ndm13
Copy link
Owner

ndm13 commented Jan 6, 2023

Currently the scrobble detection includes the currently playing track under the assumption that if it's not scrobbled already it will be. This isn't always true - apparently the Last.FM app will mark music from Google ambient music detection as now playing but will not scrobble it. There may be other situations where this happens also.

This will require reworking the now playing and history calls. If now playing is in history then we keep our current behavior, otherwise we ignore the currently playing track when reporting (don't scrobble it, record the previous track as last scrobbled, offset last run time by duration) and let the next pull scrobble it if it hasn't been scrobbled already.

@ndm13 ndm13 added the bug Something isn't working label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant