[wip] getDescendantNamespaces

Author: ndossche

ext/dom/element.c

@@ -1742,20 +1742,8 @@ zend_result dom_modern_element_substituted_node_value_write(dom_object *obj, zva
 	return SUCCESS;
 }
 
-PHP_METHOD(DOM_Element, getInScopeNamespaces)
+static void dom_element_get_in_scope_namespace_info(php_dom_libxml_ns_mapper *ns_mapper, HashTable *result, xmlNodePtr nodep, dom_object *intern)
 {
-	zval *id;
-	xmlNode *nodep;
-	dom_object *intern;
-
-	if (zend_parse_parameters_none() != SUCCESS) {
-		RETURN_THROWS();
-	}
-
-	DOM_GET_THIS_OBJ(nodep, id, xmlNodePtr, intern);
-
-	php_dom_libxml_ns_mapper *ns_mapper = php_dom_get_ns_mapper(intern);
-
 	HashTable prefix_to_ns_table;
 	zend_hash_init(&prefix_to_ns_table, 0, NULL, NULL, false);
 	zend_hash_real_init_mixed(&prefix_to_ns_table);
@@ -1775,8 +1763,6 @@ PHP_METHOD(DOM_Element, getInScopeNamespaces)
 		}
 	}
 
-	array_init_size(return_value, zend_hash_num_elements(&prefix_to_ns_table));
-
 	xmlNsPtr ns;
 	zend_string *prefix;
 	ZEND_HASH_MAP_FOREACH_STR_KEY_PTR(&prefix_to_ns_table, prefix, ns) {
@@ -1801,14 +1787,68 @@ PHP_METHOD(DOM_Element, getInScopeNamespaces)
 			ZVAL_NULL(OBJ_PROP_NUM(obj, 1));
 		}
 
-		ZVAL_OBJ_COPY(OBJ_PROP_NUM(obj, 2), &intern->std);
+		php_dom_create_object(nodep, OBJ_PROP_NUM(obj, 2), intern);
 
-		zend_hash_next_index_insert_new(Z_ARRVAL_P(return_value), &zv);
+		zend_hash_next_index_insert_new(result, &zv);
 	} ZEND_HASH_FOREACH_END();
 
 	zend_hash_destroy(&prefix_to_ns_table);
 }
 
+PHP_METHOD(DOM_Element, getInScopeNamespaces)
+{
+	zval *id;
+	xmlNode *nodep;
+	dom_object *intern;
+
+	if (zend_parse_parameters_none() != SUCCESS) {
+		RETURN_THROWS();
+	}
+
+	DOM_GET_THIS_OBJ(nodep, id, xmlNodePtr, intern);
+
+	php_dom_libxml_ns_mapper *ns_mapper = php_dom_get_ns_mapper(intern);
+
+	array_init(return_value);
+	HashTable *result = Z_ARRVAL_P(return_value);
+
+	dom_element_get_in_scope_namespace_info(ns_mapper, result, nodep, intern);
+}
+
+PHP_METHOD(DOM_Element, getDescendantNamespaces)
+{
+	zval *id;
+	xmlNode *nodep;
+	dom_object *intern;
+
+	if (zend_parse_parameters_none() != SUCCESS) {
+		RETURN_THROWS();
+	}
+
+	DOM_GET_THIS_OBJ(nodep, id, xmlNodePtr, intern);
+
+	php_dom_libxml_ns_mapper *ns_mapper = php_dom_get_ns_mapper(intern);
+
+	array_init(return_value);
+	HashTable *result = Z_ARRVAL_P(return_value);
+
+	xmlNodePtr cur = nodep->children;
+	while (cur != NULL) {
+		if (cur->type == XML_ELEMENT_NODE) {
+			/* TODO: this could be more optimized by updating the same HashTable repeatedly
+			 * instead of recreating it on every node. */
+			dom_element_get_in_scope_namespace_info(ns_mapper, result, cur, intern);
+
+			if (cur->children) {
+				cur = cur->children;
+				continue;
+			}
+		}
+
+		cur = php_dom_next_in_tree_order(cur, nodep);
+	}
+}
+
 PHP_METHOD(DOM_Element, rename)
 {
 	zend_string *namespace_uri, *qualified_name;

ext/dom/php_dom.stub.php

@@ -1379,6 +1379,9 @@ public function replaceChildren(Node|string ...$nodes): void {}
         /** @return list<NamespaceInfo> */
         public function getInScopeNamespaces(): array {}
 
+        /** @return list<NamespaceInfo> */
+        public function getDescendantNamespaces(): array {}
+
         public function rename(?string $namespaceURI, string $qualifiedName): void {}
     }