Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Suspense boundary with useSearchParams #24

Closed
HighError opened this issue Feb 2, 2024 · 2 comments
Closed

Missing Suspense boundary with useSearchParams #24

HighError opened this issue Feb 2, 2024 · 2 comments
Assignees
@ndungtse
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@HighError
Copy link

Describe the bug
Missing Suspense boundary with useSearchParams

To Reproduce
Steps to reproduce the behavior:

  1. Add Next13ProgressBar to app
  2. Build

Expected behavior
Build ok.

Screenshots
image

Additional context
You need to wrap the component in Suspend. I think it's worth adding this to the library so that the developer doesn't have to think about it.
image
@ndungtse ndungtse added duplicate This issue or pull request already exists enhancement New feature or request labels Feb 2, 2024
@ndungtse
Copy link
Owner

ndungtse commented Feb 2, 2024

This issue is the same as #18 which I moved into discussion if the feature can be added but it looks like it might be helpful to be included in package. I'll try to include it in the next versions. Thanks in advance @HighError .

@MrLoh
Copy link

MrLoh commented Feb 7, 2024

Just wasted 4 hours tracking this down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndungtse ndungtse

Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MrLoh @HighError @ndungtse