Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach a request id to response headers #199

Closed
Tracked by #242 ...
esaminu opened this issue Jul 18, 2023 · 3 comments · Fixed by #351
Closed
Tracked by #242 ...

Attach a request id to response headers #199

esaminu opened this issue Jul 18, 2023 · 3 comments · Fixed by #351
Assignees
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda

Comments

@esaminu
Copy link

esaminu commented Jul 18, 2023

In order to be able to trace errors thrown on the frontend, it's useful to have a request id header in the response that will be rendered in error toasts that the user sees. We can then query the backend logs based on the ids and trace the error more effectively.

caused by near/fast-auth-signer#15

@volovyks
Copy link
Collaborator

volovyks commented Aug 7, 2023

Related comment: near/fast-auth-signer#15 (comment)

@itegulov
Copy link
Contributor

itegulov commented Aug 8, 2023

Should we follow https://www.w3.org/TR/trace-context/? Would that be fine with you @esaminu?

@esaminu
Copy link
Author

esaminu commented Aug 10, 2023

@itegulov This looks good to me. We will display the 'traceparent' header from the response in the toast and the whole request + error can be successfully traced from a screenshot or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants