Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An awful lot of messages are getting sent #4

Open
DavidM-D opened this issue Jan 16, 2024 · 2 comments
Open

An awful lot of messages are getting sent #4

DavidM-D opened this issue Jan 16, 2024 · 2 comments

Comments

@DavidM-D
Copy link
Contributor

While working on near/mpc#412 I noticed that there are about 3 times as many messages getting sent as I'd expect when running this test. When running 10 nodes there are this many messages in sent to each node.

48
165
292
419
546
673
800
927
1054
1191

About 3% of the messages being sent are duplicates, I'd like to make sure that each message is being acted upon.

Also 9 messages are sent to completed triples even when the threshold is n/n, I'd like that behaviour to be explained and documented somewhere.

@DavidM-D
Copy link
Contributor Author

Right now, I'm going to try to build out a more robust testing framework to see if the problem persists once we have consensus ect.

@ChaoticTempest
Copy link
Contributor

Probably the duplicate messages you were seeing is the send many, where node A relays the same message to node B and node C. I had a duplicate filter for a mapping of (sender_id, receiver_id, message) -> count and saw only unique counts. Additionally, tried doing a filter on duplicate messages being sent to a receiver but that actually fails to complete the triple generation. So a node receiving the same message but from different senders is still valid

@volovyks volovyks transferred this issue from near/mpc Dec 2, 2024
@volovyks volovyks transferred this issue from another repository Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants