-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Length of buffer does not match length of ASN.1 sequence #1248
Comments
Hey @microchipgnu, we have updated the package, the problem should be solved. |
Thanks @gtsonevv we are testing now. |
Hey @gtsonevv we are seeing a new error now. This happens on all devices now.
|
Hey @microchipgnu, we will investigate why this is happening. |
@microchipgnu, is this error coming from the |
Hey @microchipgnu, could you provide a minimal reproducible example of the issue? |
Any update @vikinatora @gtsonevv? |
Hey @microchipgnu, we are still investigating the issue, please use version 2.1.4 until we resolve the issue. |
Any update? |
@SurgeCode, @microchipgnu Does the issues still persist on near-api-js v2.1.4? This issue is on our priority list, but we have a few other stuff to do, before we dive deep here. Thank you for your patience. |
1.0.1 -> Doesn't work on any window machines - Error: Length of buffer does not match length of ASN.1 sequence. 1.1.0 -> Doesn't work in general (all machines we tested)- Error: r must be 0 < r < CURVE.n reproduction -> create, get, check console https://near-biometric-issue-repro.vercel.app/ This issue is quite critical for us at the moment |
Hey, no update here unfortunately. Most likely the |
This seems pretty critical as it makes the library entirely unusable in a lot of cases. Could you give me some information on how much of a priority this is for your team or if we should explore our own implementation? |
It's high priority. @gtsonevv is on it. |
Any update? |
Hey, we’ve been investigating the issue in the past weeks. Unfortunately, no substantial progress has been made and this issue won't be a quick fix. We're researching currently what it will take to make the module working. For the time being, please use v1.0.1 which doesn't work on Windows as per your comments. |
#1309 Should resolve the issue, waiting for the CI node to be back up, so that checks can pass and we will release it. |
We will give this a try. Thanks! |
Please let us know if the issue is resolved. Package is @near-js/biometric-ed25519@1.1.2 |
The issue is still happening on Windows.
Tested on: Can you please reopen the issue! |
Reproducing the issue with the transaction that Micro provided above UIMoiAwrrU.mp4 |
Seems like the issue is there, since I got the same error message. |
@vikinatora , do you want to jam on this one over a call & close this? its been a while and Mintbase is getting a lot of not-so-happy users coz of it. |
I'm also happy to contribute to get this fixed |
Contributions are more than welcome, our team has comittment on a different group of functionalities and we're trying to solve this issue with the time we have to spare between tasks. Unfortunately, the issue here is not an easy one. |
My thoughts are to resolve the windows issue, the whole fido2-lib will have to be replaced with an alternative. Regarding the signing issue, that's probably a hard to spot bug. We've not worked on the initial implementation and it's hard to debug as there are no tests for the biometric module. |
@starpause, @myweb3gift can you try out the logic here? I've replaced the ASN.1 parsing library, maybe that will help as I couldn't reproduce the issue on my windows machine. In the app you just have to press the "Create and Get Key" button and check the console for errors. |
@vikinatora we had been chatting on telegram but thought to update the issue with my findings after you replaced the ASN.1 library. I still get an error in console: msedge_biaQLWkfaE.mp4 |
Hi, I try to log in the account with the Windows passkey, when I type the PIN it doesn't tell me it's incorrect, but it won't loge me in. Also, I have another account I'm logged on, but it's impossible to get the seed phrase. I'm using Windows 10 and latest version of Chrome. After I put the PIN, I'm back to the connection page, nothing happens. Please, advise. |
@vikinatora After bumping Mintbase Wallet dependency to @near-js/wallet-account@1.2.1 I'm still getting the ASN.1 error on my windows machine. Can you share a barebones test before pushing the next fix/update to make the feedback loop tighter? This has been open for months. Maybe fork https://near-biometric-issue-repro.vercel.app/ as shared above? |
Prerequisites
near-api-js
.Description
We have several users using Chromium-based browsers (v120+) like Brave, Chrome and Edge on Windows machines.
We integrated
@near-js/biometric-ed25519
and thegetKeys
method throws an error when executed in this environment.Reproducible demo
https://wallet.mintbase.xyz
Steps to reproduce
Expected behavior
Not to throw an error and return keys.
Actual behavior
Your environment
Self-service
The text was updated successfully, but these errors were encountered: