Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard module declaration #802

Closed
luixo opened this issue Dec 10, 2021 · 3 comments · Fixed by #807
Closed

Wildcard module declaration #802

luixo opened this issue Dec 10, 2021 · 3 comments · Fixed by #807
Assignees
Labels
Priority 2 refactoring code, configuration clean ups

Comments

@luixo
Copy link
Contributor

luixo commented Dec 10, 2021

Story

As a newcomer to this repository, I'm pretty confused with declaration declare module "*" in typescript extraneous declaration file.
It seems like a smelly code for me, combining with no monorepo tooling it caused an irritating bug of every module being linked to this declaration, effectively ruining all type checks.

Seems like this line was added to help out with absent type on datamaps module, but probably it was an overkill to add a wildcard for that.

Proposals

  • Replace wildcard module definition to datamaps module definition
  • Either update datamaps to 0.5.9 which has type definitions and write own react components or make a PR with types to react-datamaps package (propose your own solution!)
  • Be more strict on wildcards in general :)
@frol
Copy link
Collaborator

frol commented Dec 10, 2021

Given that the GeoMap Page is now dead, we may as well just remove datamaps for now.

Well, there were some historical reasons why I went stupid and merged the PR before we addressed all the code quality issues. We should definitely improve it.

@luixo If this breaks your productivity, I suggest you address this issue first.

@frol frol added Priority 2 refactoring code, configuration clean ups labels Dec 10, 2021
@luixo
Copy link
Contributor Author

luixo commented Dec 10, 2021

Given that the GeoMap Page is now dead, we may as well just remove datamaps for now.

Should we remove it completely? You can still access it via direct link.

Upd: it's been commented out for a half a year now

@frol
Copy link
Collaborator

frol commented Dec 10, 2021

Yes, go ahead and remove it completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 2 refactoring code, configuration clean ups
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants