Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for promise_batch_action_function_call_weight #175

Closed
austinabell opened this issue Aug 10, 2022 · 1 comment
Closed

Support for promise_batch_action_function_call_weight #175

austinabell opened this issue Aug 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@austinabell
Copy link
Contributor

Assumed this would be used by the SDK, but this simplifies the devX a lot because it doesn't require someone to specify gas explicitly. I have noticed developers having issues with this getting started.

There isn't really a clear path to migrate the APIs without being breaking. Basically what needs to happen is gas being made optional and also including the optional parameter of gasWeight. Possibly a non-breaking change would be to make gas optional and just add gasWeight as the next positional argument, which is not ideal because it requires specifying a gas value if you only want to modify the weight, and these can be confused.

The builder would have to be modified to include (or change) the existing near_promise_batch_action_function_call to call the updated runtime host function.

@ailisp
Copy link
Member

ailisp commented Aug 11, 2022

Great demostration on promise_batch_action_function_call_weight. We also need to figure out integration of protocol version in build cli, to include recent and future APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants