Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UTF-8 encoding / decoding and native conversion between Uint8Array and string #314

Closed
ailisp opened this issue Dec 2, 2022 · 1 comment
Closed

Add UTF-8 encoding / decoding and native conversion between Uint8Array and string #314

ailisp opened this issue Dec 2, 2022 · 1 comment
Assignees
@ailisp
Labels
v1.0

Comments

@ailisp
Copy link
Member

ailisp commented Dec 2, 2022

UTF-8 is available in quickjs C API, but it's not available in JS. Also conversion between Uint8Array and string without encoding, i.e. convert each uint8 to one character, was done in JS, which is quite inefficient. It should be in C and export to JS.
@ailisp ailisp self-assigned this Dec 2, 2022
@ailisp ailisp added the v1.0 label Dec 2, 2022
@ailisp ailisp mentioned this issue Dec 2, 2022
Merged
7 tasks
@ailisp
Copy link
Member Author

ailisp commented Dec 13, 2022

Addressed in #308

@ailisp ailisp closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ailisp ailisp

Labels
v1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ailisp