Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained crate memmap with memmap2 #759

Closed
ctindogaru opened this issue Mar 24, 2022 · 1 comment · Fixed by #817
Closed

Replace unmaintained crate memmap with memmap2 #759

ctindogaru opened this issue Mar 24, 2022 · 1 comment · Fixed by #817
Labels
T-dev-tools

Comments

@ctindogaru
Copy link
Contributor

ctindogaru commented Mar 24, 2022 •
edited by exalate-issue-sync bot
Loading

Dependency chain: near-sdk-sim -> near-runtime -> near-vm-runner -> wasmer-runtime-near -> memmap

We are using near-sdk-sim in our tests and I've noticed that an unmaintained crate is pulled indirectly via near-sdk-sim. The create is called memmap and it should be replace by its newer version memmap2.

Note that this issue was flagged by Halborn while doing an audit on our smart contracts.

Can we please get this fixed?
@austinabell
Copy link
Contributor

near-sdk-sim will be deprecated soon, see #662 for some info. We currently don't have the option to modify these internal crates to be compatible with near-sdk-sim right now.

@austinabell austinabell mentioned this issue May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-dev-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove near-sdk-sim from repo near/near-sdk-rs
2 participants
@ctindogaru @austinabell