Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font and icon support to webview #13

Open
calebjacob opened this issue Mar 31, 2023 · 1 comment
Open

Add font and icon support to webview #13

calebjacob opened this issue Mar 31, 2023 · 1 comment
Assignees

Comments

@calebjacob
Copy link

Our NEAR Discovery Viewer recently provided two global assets to all components:

These assets aren't available in the VS Code preview panel, so the fonts and icons won't render. The easiest thing to do would be to apply the same changes to your webview app:

near/near-discovery@f7a1537
near/near-discovery@2a5c22c

I'm not sure if there's a smarter way we can keep these in sync for the future.

@calebjacob calebjacob changed the title Allow injection of scripts or custom react wrapper Add font and icon support to webview Mar 31, 2023
@gagdiez
Copy link
Contributor

gagdiez commented May 18, 2023

This would be a simple change in how the components are displayed right? moreover, a change that will not be reflected in other gateways, but only the one at near.org.

Maybe it is ok if the vscode extension is gateway agnostic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants