New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet callback URL meta query parameter may be incorrect #2912

Open

trezbouchez opened this issue Sep 10, 2022 · 0 comments

trezbouchez commented Sep 10, 2022

This may be intentional, however looking at the code I think this is probably a bug:

Problem

When client passes meta to the transaction the callback URL query parameter is named 'signMeta'.

Expected Behavior

Should probably be just called 'meta'.

Steps to reproduce

Have the wallet sign a transaction and pass some meta to the RequestSignTransactionsOptions
Once the wallet does its job, inspect the callback URL query parameters

thisisjoshford added this to DevTools

github-project-automation bot moved this to NEW❗ in DevTools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment