Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspaces::types::PublicKey doesn’t implement std::hash::Hash #263

Closed
mooori opened this issue Jan 17, 2023 · 1 comment
Closed

workspaces::types::PublicKey doesn’t implement std::hash::Hash #263

mooori opened this issue Jan 17, 2023 · 1 comment

Comments

@mooori
Copy link

mooori commented Jan 17, 2023

This prevents storing it in a std::collections::HashSet, which can be helpful during testing.

workspaces::types::PublicKey is a wrapper around near_crypto::PublicKey, which implements Hash. So it should be possible for workspaces::types::PublicKey to derive Hash. Would a PR that adds Hashto the derived traits be welcome?

@ChaoticTempest
Copy link
Member

Oh thanks for bringing this up. Lots of types in workspaces are there more on a need basis, so some stuff might've been missed. There's a couple things missing from PublicKey that would be nice to have as well. I'll include this in that PR as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants