Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract RPC API client into a standalone project #1905

Closed
MaksymZavershynskyi opened this issue Dec 30, 2019 · 5 comments
Closed

Extract RPC API client into a standalone project #1905

MaksymZavershynskyi opened this issue Dec 30, 2019 · 5 comments
Assignees
Labels
A-RPC Area: rpc C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high Priority: High

Comments

@MaksymZavershynskyi
Copy link
Contributor

MaksymZavershynskyi commented Dec 30, 2019

Our current restaking tool uses RPC client that was designed to work for testing only. We should extract it into a separate proper RPC client for node.

Following the example, the name on GitHub should be near-api-rs, Crates.io - near-api, Rust use namespace - near_api.

@MaksymZavershynskyi MaksymZavershynskyi added P-high Priority: High A-RPC Area: rpc labels Dec 30, 2019
@MaksymZavershynskyi MaksymZavershynskyi added P-low Priority: low and removed P-high Priority: High labels Jan 14, 2020
@MaksymZavershynskyi MaksymZavershynskyi added P-high Priority: High and removed P-low Priority: low labels Jan 24, 2020
@MaksymZavershynskyi
Copy link
Contributor Author

MaksymZavershynskyi commented Jan 24, 2020

As discussed with Near developers it would be nice if we have cleanly extracted RPCUser without pulling too many dependencies from nearcore. Specifically, that would allow us to compile tests that use RPCUser with stable instead of nightly.

@frol frol changed the title RPC Client for node Extract RPC API client into a standalone project Mar 14, 2020
@ilblackdragon ilblackdragon modified the milestone: MainNet Mar 18, 2020
@frol frol added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label May 20, 2021
@frol frol assigned miraclx and unassigned frol Aug 4, 2021
@frol
Copy link
Collaborator

frol commented Aug 6, 2021

This issue is quite involving, and required quite some refactoring and restructuring:

@stale
Copy link

stale bot commented Nov 4, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Nov 4, 2021
@miraclx
Copy link
Contributor

miraclx commented Nov 5, 2021

Update on this: we've successfully completed the task as defined in the original comment as we do now have the new jsonrpc-client built from the ground up specifically to be approachable by actual users and outside internal testing. It currently exists in its own repo: https://github.com/near/near-jsonrpc-client-rs. And we have it published in its initial stages at https://crates.io/crates/near-jsonrpc-client.

However, the higher-level near-api-rs that should draw closer parallels to the revered near-api-js is still WIP but this would serve as a stepping stone for that endeavor.

@stale stale bot removed the S-stale label Nov 5, 2021
@frol
Copy link
Collaborator

frol commented Nov 23, 2021

I feel we can close this issue on nearcore side now, and next quarter we will lay out the plans about near-api-rs

@frol frol closed this as completed Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-RPC Area: rpc C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high Priority: High
Projects
None yet
Development

No branches or pull requests

4 participants