Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third Party Security Audit of Mainnet Genesis Contracts #2197

Closed
nearmisterwhite opened this issue Feb 26, 2020 · 4 comments
Closed

Third Party Security Audit of Mainnet Genesis Contracts #2197

nearmisterwhite opened this issue Feb 26, 2020 · 4 comments
Assignees

Comments

@nearmisterwhite
Copy link

nearmisterwhite commented Feb 26, 2020

Upd: I have added more contracts, since the review is going to be done for all of them together.

This includes the following contracts:

  • Lockup/vesting contract;
  • Staking pool;
  • Voting contract;
  • Whitelist contract;
  • Fungible token contract;

Unfortunately the first two contracts are closely tied together, specifically we will allow staking from the vesting contract only through the staking pool. This is done to reduce the complexity of the contract.

@ilblackdragon ilblackdragon added this to the MainNet milestone Mar 20, 2020
@MaksymZavershynskyi MaksymZavershynskyi removed this from the MainNet milestone Mar 21, 2020
@MaksymZavershynskyi MaksymZavershynskyi added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Mar 30, 2020
@MaksymZavershynskyi
Copy link
Contributor

Assigning 5 days/points since this would be approximate amount of time spent fixing potential issues found by the security audit. @ilblackdragon @evgenykuzyakov I suggest we engage one of the security audit companies now so that we can start planning and have them work on in immediately once our contract is ready. Any objections?

@MaksymZavershynskyi MaksymZavershynskyi changed the title Third Party Security Audit of Mainnet Genesis Vesting Smart Contract Third Party Security Audit of Mainnet Genesis Contracts May 5, 2020
@MaksymZavershynskyi
Copy link
Contributor

I have expanded the scope of this issue and changed the estimate from 5 to 21. @evgenykuzyakov please adjust it if you think it is not correct.

@MaksymZavershynskyi MaksymZavershynskyi added core-contracts and removed A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels May 16, 2020
@MaksymZavershynskyi
Copy link
Contributor

The estimate was confirmed by a third-party audit company. They have started working on it Mon, May 11. It will take them about 3 weeks to finish it. Keeping the estimate to 21 to err on the safe side.

@MaksymZavershynskyi
Copy link
Contributor

This is done. Waiting for a report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants