Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make state sync state machine more robust #3489

Open
mikhailOK opened this issue Oct 14, 2020 · 3 comments
Open

Make state sync state machine more robust #3489

mikhailOK opened this issue Oct 14, 2020 · 3 comments
Labels
A-chain Area: Chain, client & related C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@mikhailOK
Copy link
Contributor

mikhailOK commented Oct 14, 2020

It seems like currently the Client has state_sync and catchup_state_syncs only in memory, but the state sync logic writes to db (ColStateParts).

Implementing #3262 requires more state-dependent logic to write / clean up data in db, so it would be a good idea to persist the state of syncing (ShardSyncDownload), and have atomic writes for state transitions and rollback/cleanup logic from any state.

@mikhailOK mikhailOK added the A-chain Area: Chain, client & related label Oct 14, 2020
@mikhailOK mikhailOK self-assigned this Oct 14, 2020
@bowenwang1996 bowenwang1996 added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jun 29, 2021
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Sep 27, 2021
@stale
Copy link

stale bot commented Dec 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Dec 27, 2021
@stale
Copy link

stale bot commented Mar 29, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Mar 29, 2022
@akhi3030 akhi3030 removed the S-stale label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chain Area: Chain, client & related C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

3 participants