Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing::debug_span calls throughout runtime #5195

Closed
matklad opened this issue Nov 10, 2021 · 3 comments
Closed

Add tracing::debug_span calls throughout runtime #5195

matklad opened this issue Nov 10, 2021 · 3 comments
Assignees
Labels
Node Node team T-node Team: issues relevant to the node experience team

Comments

@matklad
Copy link
Contributor

matklad commented Nov 10, 2021

In #4038 we added some basic tracing support for runtime. We should complete that work and add enough spans to all the critical code-paths to get a full picture of runtime performance.

For example, right now I am debugging an estimator issue, and I am looking at the following trace:

2.01ms Runtime::process_receipt 140.25µs run_vm 134.64µs run_wasmer2 1.24µs get_key 54.26µs deserialize_wasmer2 32.21µs run_method 27.67µs run_method/instantiate 500.00ns run_method/call 1.10µs run_method/drop_instance

It would be really great to understand where those extra 1.860ms of time went!

cc @nikurt

@matklad matklad added the T-node Team: issues relevant to the node experience team label Nov 10, 2021
@stale
Copy link

stale bot commented Mar 13, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Mar 13, 2022
@nikurt
Copy link
Contributor

nikurt commented May 2, 2022

Related to #6731

@exalate-issue-sync exalate-issue-sync bot added T-nodeX and removed T-node Team: issues relevant to the node experience team labels Jun 28, 2022
@matklad matklad added T-node Team: issues relevant to the node experience team and removed T-nodeX labels Aug 4, 2022
@exalate-issue-sync
Copy link

Nikolay Kurtov commented:

Experimenting with the tracing data shows that all important pieces are annotated with tracing::debug_span or tracing::trace_span.

@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node Node team T-node Team: issues relevant to the node experience team
Projects
None yet
Development

No branches or pull requests

4 participants