Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopped Block Stream/Executor Alerts incorrectly fire #839

Closed
morgsmccauley opened this issue Jun 25, 2024 · 0 comments · Fixed by #843
Closed

Stopped Block Stream/Executor Alerts incorrectly fire #839

morgsmccauley opened this issue Jun 25, 2024 · 0 comments · Fixed by #843
Assignees
@morgsmccauley
Labels
bug Something isn't working

Comments

@morgsmccauley
Copy link
Collaborator

The logic for determining stopped block streams/executors doesn't take in to account Indexers which have deliberately been stopped/deleted. Deleted Indexers cause the alert to fire incorrectly. Additionally, now that the Redis Stream length has been capped (#812), Block Streams will pause while waiting for the Redis Stream to fall below its configured limit, which also causes the alert to fire.

These alerts should only fire when the Block Stream/Executor is truely broken.
@morgsmccauley morgsmccauley self-assigned this Jun 25, 2024
@morgsmccauley morgsmccauley added the bug Something isn't working label Jun 25, 2024
@morgsmccauley morgsmccauley linked a pull request Jun 27, 2024 that will close this issue
fix: Add metrics for reliably measuring Block Stream/Executor health #843
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgsmccauley morgsmccauley

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add metrics for reliably measuring Block Stream/Executor health near/queryapi
1 participant
@morgsmccauley