Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove and deprecate allowedDomains #230

Closed
eugenio-oddone opened this issue Aug 15, 2023 · 2 comments · Fixed by #247
Closed

Remove and deprecate allowedDomains #230

eugenio-oddone opened this issue Aug 15, 2023 · 2 comments · Fixed by #247
Assignees
@jack-robson

Comments

@eugenio-oddone
Copy link
Contributor

Mentioned in #229

Currently we are preserving the compatibility. Should remove the allowedDomains option altogether. This will be a breaking change. Include a migration approach and introduce the new issuersWhitelist.
@eugenio-oddone eugenio-oddone mentioned this issue Aug 15, 2023
Merged
@simoneb
Copy link
Member

simoneb commented Aug 16, 2023

This will have to be done with a major release

@jack-robson jack-robson self-assigned this Oct 16, 2023
@jack-robson jack-robson mentioned this issue Oct 16, 2023
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jack-robson jack-robson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: remove last allowedDomains reference nearform/get-jwks
3 participants
@simoneb @eugenio-oddone @jack-robson