fix(LocalGraphQLClient): handle middleware and responseReducer #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G100g
force-pushed
the
handle-middleware-and-responsereducer-localgraphqlclient
branch
from
53f6da1 to
df93b51
Compare
bilalshareef
approved these changes
Jul 18, 2024
| const { data, errors } = collectErrorsFromObject(result) | ||
| if (errors.length > 0) { | ||
| const { data, errors } = collectErrors(result) | ||
| if (errors && errors.length > 0) { |
There was a problem hiding this comment.
nitpick: This line can be if (errors?.length > 0) {
There was a problem hiding this comment.
Thanks for the feedback.
I tried to use it before push the code, but I got this error from TS
So I preferred to stay with this version :D
There was a problem hiding this comment.
Oh okay. The current code looks good to me then. 🙂
simoneb
approved these changes
Jul 22, 2024
simoneb
deleted the
handle-middleware-and-responsereducer-localgraphqlclient
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Let
LocalGraphQLClientto handlemiddlewareandresponseReducerRelated issues
resolve #1196
Checklist