Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Running initium-cli from local after ci doesn't seem to update the container on the platform #103

Closed
LucaLanziani opened this issue Sep 11, 2023 · 3 comments · Fixed by #117
Assignees

Comments

@LucaLanziani
Copy link
Member

Changing the code and running initium-cli onbranch locally after a pipeline did not change the output of the deployed application.

Steps to reproduce

  1. Follow the quick start and deploy the code from branch
  2. Add an extra ! to the Hello World! message
  3. Run initium-cli onbranch from your local copy of the repo
  4. curl the endpoind you should have Hello World!!
@zaremba-tomasz
Copy link
Contributor

Note for myself: image uploaded to the repository contains changes, knative deployment pod is using the old image for some reason.

@zaremba-tomasz
Copy link
Contributor

zaremba-tomasz commented Sep 26, 2023

@LucaLanziani the case is reproducible on CI as well:

  1. PR creation and initial deployment works as expected.
  2. Second commit to the same PR works as expected.
  3. Third and subsequent changes are not reflected. SHA of an image is not refreshed by subsequent update calls.

Knative resolve images up to digest (see docs) and it seems that subsequent servingClient.Services(serviceManifest.ObjectMeta.Namespace).Update(ctx, service, metav1.UpdateOptions{}) calls are not recognized as changes (when digest is omitted by the CLI).

My suggestion to solve this issue is to pass to the manifest not only the <image-name>:<image-tag> but extend it to <image-name>:<image-tag>@<digest> and be explicit about the image we would like to deploy.

WDYT?

@LucaLanziani
Copy link
Member Author

100% that works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants