Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code refactoring and cleanup #156

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

LucaLanziani
Copy link
Member

No description provided.

Copy link
Contributor

@mablanco mablanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucaLanziani
Copy link
Member Author

The PR contains a bug, I'll fix it today
image

@LucaLanziani LucaLanziani force-pushed the chore/correct-pr-comment-behaviour branch from 74e300b to 48dafce Compare November 30, 2023 08:36
@LucaLanziani
Copy link
Member Author

PR ready to review @mablanco @dublx
image

@mablanco mablanco requested review from dublx and mablanco November 30, 2023 12:11
Copy link
Contributor

@mablanco mablanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM also

@LucaLanziani LucaLanziani merged commit b08bdd7 into main Nov 30, 2023
1 check passed
@LucaLanziani LucaLanziani deleted the chore/correct-pr-comment-behaviour branch November 30, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants