Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Ability to start stopped shared app, by NOT author #483

Closed
aktech opened this issue Sep 19, 2024 · 4 comments · Fixed by #487
Closed

[ENH] - Ability to start stopped shared app, by NOT author #483

aktech opened this issue Sep 19, 2024 · 4 comments · Fixed by #487

Comments

@aktech
Copy link
Member

aktech commented Sep 19, 2024

Feature description

Imagine two users, Alice and Bob.

Alice creates an app named "Alice in Wonderland" and shares it with Bob. Now when the app is stopped after a while, say by idle culling and Bob access that app, he can't use the app as it's stopped.

We need the ability to start the app "Alice in Wonderland" by Bob.

The assumption is Bob has sufficient permissions in JupyterHub to start the app (otherwise 403).

Value and/or benefit

Following problems will be solved:

  • The problem of keeping the app always alive (causing cost) will be solved.
  • The problem of being able to access a stopped app, when the original author is not available.

Anything else?

No response

@aktech aktech changed the title [ENH] - Ability to start stopped shared app [ENH] - Ability to start stopped shared app by NOT author Sep 19, 2024
@aktech aktech changed the title [ENH] - Ability to start stopped shared app by NOT author [ENH] - Ability to start stopped shared app, by NOT author Sep 19, 2024
@kcpevey
Copy link
Contributor

kcpevey commented Sep 19, 2024

The assumption is Bob has sufficient permissions in JupyterHub to start the app (otherwise 403).

What roles are required for "sufficient permissions"?

@aktech
Copy link
Member Author

aktech commented Sep 24, 2024

What roles are required for "sufficient permissions"?

We need a custom role with scope "servers" (this can be limited by servers of a user or group as well) for the user to have permissions to start the app.

@aktech aktech mentioned this issue Oct 1, 2024
18 tasks
@aktech aktech added this to the Release 2024.10.1 milestone Oct 14, 2024
@kildre
Copy link
Contributor

kildre commented Nov 22, 2024

@aktech This is only for Starting an app correct? A shared user still cannot Stop an app?

@aktech
Copy link
Member Author

aktech commented Nov 22, 2024

@aktech This is only for Starting an app correct? A shared user still cannot Stop an app?

Technically yes, but not enabled by backend at the moment, but I would say to frontend should make an API call to stop (just like other stop app call) and if the response is 4xx then message user, you don't have permissions to stop.

So that if we enable stopping shared app in future then it would work right away without any frontend changes.

@kildre kildre mentioned this issue Dec 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants