Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Send server owner when starting shared server #529

Closed
aktech opened this issue Nov 14, 2024 · 1 comment
Closed

[ENH] Send server owner when starting shared server #529

aktech opened this issue Nov 14, 2024 · 1 comment

Comments

@aktech
Copy link
Member

aktech commented Nov 14, 2024

Context

When starting a shared server, by the user who is not the owner of that server, we're currently only sending the server name to the API call: POST /server/<server-name>,

We should send server owner as well, probably as a query param:
POST /server/<server-name>?owner=username

This information is already available in the frontend in the url of the app, for example:
https://<HUB-URL>/hub/user/<USERNAME>/server-name/

Value and/or benefit

This was not a problem until now as the server names were unique across the system due to the appended 6 character suffix in the server name.

We're now implementing deterministic server url here: #475
Which would mean the server name would not be unique across the system and knowing who owns the server is important to be able to start the right server.

Anything else?

No response

@aktech aktech added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Nov 14, 2024
@aktech aktech removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label Nov 15, 2024
@kildre kildre mentioned this issue Nov 18, 2024
18 tasks
@aktech
Copy link
Member Author

aktech commented Nov 20, 2024

Fixed in #533

@aktech aktech closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant