Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Add pip packages to environment section of qhub-config breaks deployment #1207

Closed
iameskild opened this issue Mar 29, 2022 · 0 comments · Fixed by #1213
Closed

[BUG] - Add pip packages to environment section of qhub-config breaks deployment #1207

iameskild opened this issue Mar 29, 2022 · 0 comments · Fixed by #1213
Labels
type: bug 🐛 Something isn't working

Comments

@iameskild
Copy link
Member

iameskild commented Mar 29, 2022

OS system and architecture in which you are running QHub

Ubuntu (GitHub Actions)

Expected behavior

Adding a pip package to an environment in the qhub-config.yaml should build the environment.

This package was added to qhub-deployment-quansight-beta.

  environment-eae.yaml:
    name: eae
    channels:
    - conda-forge
    dependencies:
    - python
    - ipykernel
    - ipywidgets
    - numpy
    - pandas
    - pip:    <-- cause of the issue
      - requests

Actual behavior

Attempting to deploy the qhub-config.yaml with new environment listed above results in a failed deployment:

INFO:qhub.provider.terraform:terraform apply directory=stages/07-kubernetes-services
...
...
[terraform]: │ Error: Invalid value for module argument
[terraform]: │ 
[terraform]: │   on jupyterhub.tf line 103, in module "jupyterhub":
[terraform]: │  103:   conda-store-environments = var.conda-store-environments
[terraform]: │ 
[terraform]: │ The given value is not suitable for child module variable
[terraform]: │ "conda-store-environments" defined at
[terraform]: │ modules/kubernetes/services/jupyterhub/variables.tf:114,1-36: all map
[terraform]: │ elements must have the same type.

How to Reproduce the problem?

In the environment section of the qhub-config.yaml, add a pip package to be included to a new environment or to an existing one. Then redeploy.

Command output

No response

Versions and dependencies used.

No response

Compute environment

No response

Integrations

No response

Anything else?

No response

@iameskild iameskild added the type: bug 🐛 Something isn't working label Mar 29, 2022
@magsol magsol added this to the POST Release v0.4.0 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants