Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update trigger settings for local Kubernetes test #1286

Closed
viniciusdc opened this issue May 16, 2022 · 1 comment
Closed

[ENH] Update trigger settings for local Kubernetes test #1286

viniciusdc opened this issue May 16, 2022 · 1 comment
Labels
area:developer-experience 👩🏻‍💻 needs: discussion 💬 Needs discussion with the rest of the team needs: follow-up 📫 Someone needs to get back to this issue or PR

Comments

@viniciusdc
Copy link
Contributor

I am opening this issue as a matter of discussion. The current trigger aspect of the Kubernetes test is the following:

on:
  pull_request:
    paths:
      - ".github/workflows/kubernetes_test.yaml"
      - "tests/**"
      - "tests_deployment/**"
      - "tests_e2e/**"
      - "scripts/**"
      - "qhub/**"
      - "setup.cfg"
      - "pyproject.yoml"
  push:
    branches:
      - main
    paths:
      - ".github/workflows/kubernetes_test.yaml"
      - "tests/**"
      - "tests_deployment/**"
      - "tests_e2e/**"
      - "scripts/**"
      - "qhub/**"
      - "setup.cfg"
      - "pyproject.yoml"

Though it does its work on validating that any change made into qhub infrastructure-related config is fully* tested -- by fully I mean an end-to-end deployment for Minikube Qhub. This sometimes can become a long waiting process over changes that are not entirely subject to a Qhub deployment. For example, in this recent #1282 if you look at the changes, you will see that there is no need for a full deployment of Qhub (its contrapositive to test this) in this case.

My main points over the current structure are:

  • It takes a long waiting process to get a green stage for merging,
  • It's using our own resources for this test, so reducing the usage is appreciated when it's not really needed
  • Is inconvenience and contra-productive when the changes really do not affect terraform code itself (remember that we do have the integration tests as well)
  • Not targeting the Python parts in this full deploy test, would help us create better specific Pytest scenarios to test using only python-based actions (which run much faster)

So I would like to change the above trigger conditions to only trigger by direct changes in the package configuration or the terraform stages:

on:
  pull_request:
    paths:
      - ".github/workflows/kubernetes_test.yaml"
      - "qhub/template/stages/*"
      - "setup.cfg"
      - "pyproject.yoml"

Would like to know what everyone think

@viniciusdc viniciusdc added area: architecture area:developer-experience 👩🏻‍💻 needs: discussion 💬 Needs discussion with the rest of the team needs: follow-up 📫 Someone needs to get back to this issue or PR labels May 16, 2022
@kcpevey
Copy link
Contributor

kcpevey commented Aug 16, 2022

Closed following the kind implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:developer-experience 👩🏻‍💻 needs: discussion 💬 Needs discussion with the rest of the team needs: follow-up 📫 Someone needs to get back to this issue or PR
Projects
None yet
Development

No branches or pull requests

3 participants