Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VScode extension terminal is not loading #1369

Closed
viniciusdc opened this issue Jul 12, 2022 · 3 comments
Closed

[BUG] VScode extension terminal is not loading #1369

viniciusdc opened this issue Jul 12, 2022 · 3 comments
Assignees
Labels
area: JupyterLab needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: bug 🐛 Something isn't working

Comments

@viniciusdc
Copy link
Contributor

After #1360 was introduced, we lost the ability to use the inbuilt terminal from within the VScode extension.

This is the current status of the terminal when we attempt to load it:

image

and this is the extension manager logs:

[2022-07-12 12:13:24.491] [window] [error] [object Event]: Error: [object Event]
    at Object.E [as ensureError] (https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:4182)
    at i._createLoadError (https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:8131)
    at i._onLoadError (https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:8250)
    at f (https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:10089)
    at Object.errorback (https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:10445)
    at e.triggerErrorback (https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:11144)
    at https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:10850
    at HTMLScriptElement.f (https://quansight-beta.qhub.dev/user/vcerutti@quansight.com/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:11365)

Logs from DevTools:
image

@viniciusdc viniciusdc added type: bug 🐛 Something isn't working area: JupyterLab needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug labels Jul 12, 2022
@viniciusdc
Copy link
Contributor Author

This docs might be useful for debugging strategies https://code.visualstudio.com/docs/supporting/troubleshoot-terminal-launch

@viniciusdc
Copy link
Contributor Author

So, the problems seem to be from the current installation, see this failed network request from the current vscode on quansight-beta:

Request URL: https://quansight-beta.qhub.dev/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html?&vscodeWebWorkerExtHostId=6647b909-3bd4-4cad-8e7e-3e6ad0d626a4
Request Method: GET
Status Code: 404 
Remote Address: 35.192.125.145:443
Referrer Policy: strict-origin-when-cross-origin

and a useful one from the previous install:

Request URL: https://quansight.qhub.dev/user/vcerutti@quansight.com/vscode/static/out/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html?&vscodeWebWorkerExtHostId=b3dfe16f-b3d7-44c5-a381-e8dcd2f29ec9
Request Method: GET
Status Code: 200 
Remote Address: 35.225.175.249:443
Referrer Policy: strict-origin-when-cross-origin

It seems that the proxy for vscode is not correctly configured right now, the current endpoint being accessed is /stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs where it should be /user/vcerutti@quansight.com/vscode/static/out/vs

@kcpevey
Copy link
Contributor

kcpevey commented Aug 4, 2022

This has been resolved. Thanks guys!

Related: #1383 and nebari-dev/nebari-docker-images#14

@kcpevey kcpevey closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: JupyterLab needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants