Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update upgrade command mechanics after migration #1512

Closed
viniciusdc opened this issue Oct 25, 2022 · 2 comments
Closed

[ENH] Update upgrade command mechanics after migration #1512

viniciusdc opened this issue Oct 25, 2022 · 2 comments
Labels
needs: discussion 💬 Needs discussion with the rest of the team type: enhancement 💅🏼 New feature or request type: question 🤔 Further information is requested

Comments

@viniciusdc
Copy link
Contributor

viniciusdc commented Oct 25, 2022

After migrating qhub to nebari, we should review upgrade logic mechanics to accept qhub-config.yaml and nebari-config.yaml files and the different version schematics. Or remove it

@viniciusdc viniciusdc added this to the Future Planning milestone Oct 25, 2022
@viniciusdc
Copy link
Contributor Author

viniciusdc commented Oct 26, 2022

Ok... so this mechanic was created to help the user migrate Qhub (v0.3.*) to (v0.4.0)... but we stopped maintaining it since v0.4.3.

In theory, for each new release that changed or added some requirements to the qhub-config.yaml, the upgrade command would be able to easily update the config when updating the version... but I am not sure if we've been using it.

So, now that we are migrating to calver/Nebari and we are almost very far away from v0.3.*, I would like to raise the possibility of removing this functionally as, at least in my opinion, this looks deprecated now.

If we opt for maintaining this, then we will need to refactor it to accommodate the upgrade steps from Qhub(0.3.* -> 0.4.5) as well as Qhub (v0.4.5) -> Nebari 2022.10.1 (and future releases), which comprehends the following changes:

  • a logic conditional to check for qhub-config and nebari-config
  • A refactor in the whole mechanic... if the package name matches nebari upgrade should behave differently and upgrade the config contents based on 2022.10.1 nebari-qhub.yaml file, not based on a qhub-generated one.

@viniciusdc viniciusdc added type: enhancement 💅🏼 New feature or request needs: discussion 💬 Needs discussion with the rest of the team type: question 🤔 Further information is requested labels Oct 26, 2022
@viniciusdc viniciusdc changed the title Update upgrade command mechanics after migration [ENH] Update upgrade command mechanics after migration Oct 28, 2022
@iameskild
Copy link
Member

For the past few releases we have updated the upgrade command while retaining the old qhub upgrades. Closing this issue.

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 Needs discussion with the rest of the team type: enhancement 💅🏼 New feature or request type: question 🤔 Further information is requested
Projects
Development

No branches or pull requests

2 participants