Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Argo Workflows tab shows up in JupyterHub even when Argo Workflows is disabled #1669

Open
Adam-D-Lewis opened this issue Mar 2, 2023 · 4 comments
Labels

Comments

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Mar 2, 2023

Describe the bug

Argo Workflows tab shows up in JupyterHub when Argo Workflows is disabled

# nebari-config.yaml
...
argo_workflows:
  enabled: false

but you still see a tab for it in Jupyterhub
image

Expected behavior

No tab when argo workflows is disabled or a page saying "Argo Workflows is disabled. Contact your admin to enable it."

OS and architecture in which you are running Nebari

N/A

How to Reproduce the problem?

see above

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

@Adam-D-Lewis Adam-D-Lewis added type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels Mar 2, 2023
@Adam-D-Lewis Adam-D-Lewis changed the title [BUG] - Argo Workflows tab shows up in JupyterHub when Argo Workflows is disabled [BUG] - Argo Workflows tab shows up in JupyterHub even when Argo Workflows is disabled Mar 2, 2023
@kcpevey kcpevey added area: integration/Argo and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Aug 8, 2023
@marcelovilla
Copy link
Member

We probably need to take this into account in the new Nebari menu item; see #2182.

@dharhas
Copy link
Member

dharhas commented Feb 16, 2024

I think the new jhub-apps ui, lets you control this more. i.e many of these are optional services and we need a way for the menu and the jhub-app ui to pull the list of services from the config file.

cc: @jbouder

@jbouder
Copy link
Contributor

jbouder commented Feb 16, 2024

Correct, currently Argo Workflows would only display in the new UI if it was added to the jupyterhub services config.

@marcelovilla
Copy link
Member

marcelovilla commented Feb 16, 2024

I think we could adapt or work on top of #2249 to achieve that. @krassowski worked on being able to pass items from the configuration to the overrides.json file. It would be a matter of passing some of them under the hood based on what services were enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New 🚦
Development

No branches or pull requests

5 participants