-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify y/N questions with an "Enter" key press throughout #1742
Comments
Hello! I am looking to make my first contribution, can you please elaborate the issue? |
@AM-O7 Welcome, and thanks for your interest in contributing! I've updated the issue description with more details, please feel free to ask if anything is unclear and/or you need help with something. :) |
Hey, Sorry it took me time to respond but I've fixed the issue in a fork I created, it was a simple fix where I added auto_enter = False in every questionary.confirm method, I have updated the init.py file in my fork, Can you tell me what should I do next? |
@AM-O7 make sure that in your fork you have created a branch named something like "feature/remove-auto-enter-cli" or similar and then create a pull request from that branch and reference this issue in the pr. Once the PR is made, we can comment on any changes that might be needed before merging it in. |
Thank you, I did it, Can you check? |
Can you close your existing PR, rename your branch as described in my earlier comment above and then make a new PR from your renamed branch. |
Is this correct? |
Yes, thank you. We will review the PR. |
Thank you! |
General context
This issue is a part of a broader effort to improve the experience around Nebari's
guided-init
CLI.You can check out this interface on installing Nebari and running
nebari init --guided-init
.Details around issue
There are some Yes/No questions in the guided-init questionnaire. These get completed on pressing "Y" or "N", before you press "Enter". However, the other questions where you need to select from a dropdown, or type-in something do require you to press "Enter" to continue. This is an inconsistent experience.
Originally posted here: #1478 (comment)
How to resolve?
For Yes/No questions, wait for the user to press "Enter" before moving on
Relevant section of codebase: https://github.com/nebari-dev/nebari/tree/develop/nebari/cli
The text was updated successfully, but these errors were encountered: