Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify y/N questions with an "Enter" key press throughout #1742

Closed
Tracked by #1478
pavithraes opened this issue Apr 22, 2023 · 9 comments
Closed
Tracked by #1478

Unify y/N questions with an "Enter" key press throughout #1742

pavithraes opened this issue Apr 22, 2023 · 9 comments
Labels

Comments

@pavithraes
Copy link
Member

pavithraes commented Apr 22, 2023

General context

This issue is a part of a broader effort to improve the experience around Nebari's guided-init CLI.

You can check out this interface on installing Nebari and running nebari init --guided-init.

Details around issue

There are some Yes/No questions in the guided-init questionnaire. These get completed on pressing "Y" or "N", before you press "Enter". However, the other questions where you need to select from a dropdown, or type-in something do require you to press "Enter" to continue. This is an inconsistent experience.

Originally posted here: #1478 (comment)

How to resolve?

For Yes/No questions, wait for the user to press "Enter" before moving on

Relevant section of codebase: https://github.com/nebari-dev/nebari/tree/develop/nebari/cli

@heyayush09
Copy link
Contributor

Hello! I am looking to make my first contribution, can you please elaborate the issue?

@pavithraes
Copy link
Member Author

@AM-O7 Welcome, and thanks for your interest in contributing! I've updated the issue description with more details, please feel free to ask if anything is unclear and/or you need help with something. :)

@heyayush09
Copy link
Contributor

Hey, Sorry it took me time to respond but I've fixed the issue in a fork I created, it was a simple fix where I added auto_enter = False in every questionary.confirm method, I have updated the init.py file in my fork, Can you tell me what should I do next?

@dharhas
Copy link
Member

dharhas commented Apr 24, 2023

@AM-O7 make sure that in your fork you have created a branch named something like "feature/remove-auto-enter-cli" or similar and then create a pull request from that branch and reference this issue in the pr. Once the PR is made, we can comment on any changes that might be needed before merging it in.

@heyayush09
Copy link
Contributor

Thank you, I did it, Can you check?

@dharhas
Copy link
Member

dharhas commented Apr 24, 2023

Can you close your existing PR, rename your branch as described in my earlier comment above and then make a new PR from your renamed branch.

@heyayush09
Copy link
Contributor

Is this correct?

@dharhas
Copy link
Member

dharhas commented Apr 24, 2023

Yes, thank you. We will review the PR.

@heyayush09
Copy link
Contributor

Thank you!

@pavithraes pavithraes moved this from New 📬 to Scoped 📁 in 🪴 Nebari Project Management Aug 25, 2023
@dcmcand dcmcand closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Ready 🔔 to Done 💪🏾 in 🪴 Nebari Project Management Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants