[BUG] - Contributor workflow comment trigger does not work properly

[pmeier]

Describe the bug

By commenting /bot run tests as a maintainer on a PR, we should be able to trigger some workflows that are usually not run for regular contributors. This is done through this workflow

nebari/.github/workflows/contributor.yaml

Lines 1 to 5 in 6b38c8c

	name: Contributor Tests trigger
	on:
	issue_comment:
	types: [created, edited]

The trigger works fine until it comes to checking the permissions of the user sending the comment. We currently check for these roles

nebari/.github/workflows/contributor.yaml

Line 31 in 6b38c8c

if: ${{ !contains(fromJson('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association) }}

They are correct according to the documentation:

author_association string Required

How the author is associated with the repository.

Can be one of: COLLABORATOR, CONTRIBUTOR, FIRST_TIMER, FIRST_TIME_CONTRIBUTOR, MANNEQUIN, MEMBER, NONE, OWNER

However, I and @iameskild as well, are listed as CONTRIBUTOR, although we should have MAINTAINER permissions.

Expected behavior

Being able to trigger contributor tests as maintainer.

OS and architecture in which you are running Nebari

GitHub repository

How to Reproduce the problem?

Comment /bot run tests on a PR, e.g. #1725. Curious to see what the bot spits out for people with elevated permissions.

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

[pmeier]

There is this discussion https://github.com/orgs/community/discussions/18690 where people seem to have the same issue. @aktech Do you have any additional insights on this since your comment?

[pmeier]

Looking at my settings, I'm listed as "moderator"

Meaning, maybe GHA is not wrong here, but our permissions are setup wrong?

[aktech]

Hey @pmeier (and @iameskild) you'd need to change your Organisation visibility to Public, for it to identify both of you as MEMBER as described in the comment I made there.

Here is mine:

[pmeier]

I don't see any such option in my personal settings. Are you sure that we have to do it on our side or does this happen on the organization level by an admin? If we need to do it, could you post minimal step-by-step instructions on how to get there?

[aktech]

You can change the toggle here (next to your username): https://github.com/orgs/nebari-dev/people

[pmeier]

That works, thanks!