Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Allow setting region during init #1824

Closed
pmeier opened this issue May 24, 2023 · 2 comments · Fixed by #1930
Closed

[ENH] - Allow setting region during init #1824

pmeier opened this issue May 24, 2023 · 2 comments · Fixed by #1930
Labels
help wanted Extra attention is needed impact: medium 🟨 This item affects some users, not critical needs: PR 📬 This item has been scoped and needs to be worked on type: enhancement 💅🏼 New feature or request

Comments

@pmeier
Copy link
Member

pmeier commented May 24, 2023

Feature description

We currently hard-code the following regions based on the cloud provider the user selects:

nebari/nebari/initialize.py

Lines 217 to 218 in 1413b95

DIGITAL_OCEAN = {
"region": "nyc3",

nebari/nebari/initialize.py

Lines 228 to 230 in 1413b95

GOOGLE_PLATFORM = {
"project": "PLACEHOLDER",
"region": "us-central1",

nebari/nebari/initialize.py

Lines 239 to 240 in 1413b95

AZURE = {
"region": "Central US",

nebari/nebari/initialize.py

Lines 260 to 261 in 1413b95

AMAZON_WEB_SERVICES = {
"region": "us-west-2",

However, similar to the deploy target, the region has no good default value. Worse, nebari init doesn't even give you the option to set the region and one has to manually edit the yaml afterwards.

  1. We should expose a --region option on nebari init
  2. The option should be required in case a new cloud provider, i.e. not "local" or "existing" is used as deploy target.

For the guided init, we should add a question for the region (preferably a populated list) that will be displayed if the user selects one of the cloud providers.

Value and/or benefit

Less frustration due to failed deploys and time needed manually editing the config yaml.

Anything else?

No response

@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request needs: PR 📬 This item has been scoped and needs to be worked on impact: medium 🟨 This item affects some users, not critical labels May 26, 2023
@pavithraes
Copy link
Member

@iameskild - Can be added to the "Advanced Configuration" section of guided init

@pavithraes pavithraes added the help wanted Extra attention is needed label Jun 19, 2023
@pmeier
Copy link
Member Author

pmeier commented Jun 19, 2023

I don't think it falls under "advanced". We don't want a default value in case the user specifies a cloud provider. However, since most people will not open the advanced settings, we'll need to have a default if we put it there.

@pavithraes pavithraes moved this from New 📬 to In progress 🏗 in 🪴 Nebari Project Management Aug 25, 2023
@github-project-automation github-project-automation bot moved this from In progress 🏗 to Done 💪🏾 in 🪴 Nebari Project Management Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed impact: medium 🟨 This item affects some users, not critical needs: PR 📬 This item has been scoped and needs to be worked on type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants