Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Move hidden login files to a single directory #1899

Closed
kcpevey opened this issue Aug 10, 2023 · 5 comments · Fixed by #2578
Closed

[ENH] - Move hidden login files to a single directory #1899

kcpevey opened this issue Aug 10, 2023 · 5 comments · Fixed by #2578
Labels
area: integration/code-server area: user experience 👩🏻‍💻 good first issue Good for newcomers needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: enhancement 💅🏼 New feature or request

Comments

@kcpevey
Copy link
Contributor

kcpevey commented Aug 10, 2023

Feature description

Every time you log into nebari, a hidden directory is created with the .bash_logout, .bashrc, and .profile in the home directory. From the Jupyter UI you can't see any of these hidden directories, but from vs code...

image

I've been on this deployment for a little over a month and I already have 184 of these. It makes using VS Code pretty frustrating when you have to scroll past all of these.

I propose that we store these files in a SINGLE hidden directory off of home.

Value and/or benefit

Happy VS Code users.

Anything else?

No response

@iameskild
Copy link
Member

I'm not sure why this file is being created...
There might be a setting in code-server (VScode) that allows us to hide specific files/folders:

files.exclude": {
  "**/.DS_Store": false,
   ...
}

Another option might include running a script that clears this file everything the user logs in (this results in a single file being present after each login).

@iameskild iameskild added the good first issue Good for newcomers label Aug 14, 2023
@kcpevey
Copy link
Contributor Author

kcpevey commented Aug 16, 2023

There might be a setting in code-server (VScode) that allows us to hide specific files/folders:

The filename a date and a hash, its not constant. I guess you could exclude files that start with the year, but that seems dangerous.

Another option might include running a script that clears this file everything the user logs in (this results in a single file being present after each login).

That could work with some regex, but I think we need to understand what is creating this file and why is it being created.

@kcpevey kcpevey added needs: discussion 💬 Needs discussion with the rest of the team and removed good first issue Good for newcomers labels Aug 25, 2023
@bmwoodruff
Copy link

I have been using Nebari with the POSSEE genai-numpy project, and I have the same issue. The new folder that gets created with every login causes a problem for me on both VS code and JupyterLab, provided you make hidden files visible on JupyterLab (I always prefer to have hidden files visible). Placing these folders in a single directory would be great. The folders and files are owned by root, with group permission root, so there's no way a user without root access can do anything to them.

@kcpevey
Copy link
Contributor Author

kcpevey commented Jul 22, 2024

I think the first step here is to explore why these files exist in the first place. If we don't actually use or need them for any reason, then it would be best just to avoid writing them in the first place.

@kcpevey kcpevey added good first issue Good for newcomers needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug and removed needs: discussion 💬 Needs discussion with the rest of the team labels Jul 22, 2024
@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jul 23, 2024

This is an implementation detail caused by the way kubernetes mounts configmaps. We were then copying those extra files to the home directory from the init container. I've opened a PR that fixes this going forwards. You'd still need to ask an admin to delete any accumulated files for you.

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/code-server area: user experience 👩🏻‍💻 good first issue Good for newcomers needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants