Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - nebari upgrade prompts for image tag upgrade excessively #1960

Open
Tracked by #1478
sblair-metrostar opened this issue Aug 29, 2023 · 0 comments
Open
Tracked by #1478
Labels
area: nebari-cli type: bug 🐛 Something isn't working

Comments

@sblair-metrostar
Copy link
Contributor

Describe the bug

Running nebari upgrade ... on a file that includes match image tags will prompt the user separately to upgrade each image tag found for each upgrade step incurred. For example, upgrading from 2023.4.1 to 2023.7.2 with default_images and custom profiles[].kubespawner_override fields can result in 8 or more y/n prompts. The final version is the only one that matters in this context, and its arguable that the individual images are also redundant. These prompts should be minimized.

Expected behavior

  1. Only prompt to upgrade to the final image in the upgrade path, skipping intermediate steps.
  2. Maybe just assume a single y/n is sufficient to upgrade them all, rather than individually.

OS and architecture in which you are running Nebari

Ubuntu Linux, x64

How to Reproduce the problem?

Run nebari upgrade -c nebari-config.yaml with something resembling the following in the file.

default_images:
  jupyterhub: quay.io/nebari/nebari-jupyterhub:2023.4.1
  jupyterlab: quay.io/nebari/nebari-jupyterlab:2023.4.1
  dask_worker: quay.io/nebari/nebari-dask-worker:2023.4.1
profiles:
  jupyterlab:
  - display_name: test
    kubespawner_override:
      image: quay.io/nebari/nebari-jupyterlab:2023.4.1

image

Command output

No response

Versions and dependencies used.

Nebari: 2023.7.2.dev

Compute environment

None

Integrations

No response

Anything else?

No response

@sblair-metrostar sblair-metrostar added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Aug 29, 2023
@pavithraes pavithraes added area: nebari-cli project: JATIC Work item needed for the JATIC project and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Aug 30, 2023
@pavithraes pavithraes moved this from New 🚦 to Ready 🔔 in 🪴 Nebari Project Management Sep 8, 2023
@kcpevey kcpevey removed the project: JATIC Work item needed for the JATIC project label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nebari-cli type: bug 🐛 Something isn't working
Projects
Status: Ready 🔔
Development

No branches or pull requests

3 participants