Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Override theme when using jhub-apps #2208

Closed
aktech opened this issue Jan 17, 2024 · 1 comment
Closed

[ENH] - Override theme when using jhub-apps #2208

aktech opened this issue Jan 17, 2024 · 1 comment
Milestone

Comments

@aktech
Copy link
Member

aktech commented Jan 17, 2024

Feature description

The way styling works at the moment is via:

if z2jh.get_config("custom.jhub-apps-enabled"):
from jhub_apps import themes
c.JupyterHub.template_vars = {**jupyterhub_theme, **themes.DEFAULT_THEME}

if z2jh.get_config("custom.jhub-apps-enabled"):
    from jhub_apps import themes

    c.JupyterHub.template_vars = {**jupyterhub_theme, **themes.DEFAULT_THEME}

The current flow is:
- Use default theme param or user supplied (from nebari config) params when not using jhub apps
- Use jhub apps theme when using jhub apps

We need to provide a priority/mechanism to override jhub-apps theme params when using jhub-apps.

Value and/or benefit

To be able to customise colors based on brand colors of the organization.

Anything else?

No response

@aktech
Copy link
Member Author

aktech commented Jan 23, 2024

Fixed in #2215

@aktech aktech closed this as completed Jan 23, 2024
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants