Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Highest support k8s version not supported on DigitalOcean #2285

Closed
aktech opened this issue Mar 2, 2024 · 2 comments
Closed

[BUG] - Highest support k8s version not supported on DigitalOcean #2285

aktech opened this issue Mar 2, 2024 · 2 comments

Comments

@aktech
Copy link
Member

aktech commented Mar 2, 2024

Describe the bug

HIGHEST_SUPPORTED_K8S_VERSION is ("1", "26", "9")

HIGHEST_SUPPORTED_K8S_VERSION = ("1", "26", "9")

Where as the supported k8s versions on DigitalOcean:

$ doctl kubernetes options versions
Slug            Kubernetes Version    Supported Features
1.29.1-do.0     1.29.1                cluster-autoscaler, docr-integration, ha-control-plane, token-authentication
1.28.6-do.0     1.28.6                cluster-autoscaler, docr-integration, ha-control-plane, token-authentication
1.27.10-do.0    1.27.10               cluster-autoscaler, docr-integration, ha-control-plane, token-authentication

Expected behavior

Highest supported version, supported on DO

OS and architecture in which you are running Nebari

MacOS (12.3 (21E230))

How to Reproduce the problem?

Initialise Nebari for DO:

nebari init "do" --project "TestProvider" --domain "do.nebari.dev" --auth-provider password --disable-prompt --ci-provider github-actions

Command output

Defaulting to region:`nyc3`.
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ /Users/aktech/quansight/nebari/src/_nebari/subcommands/init.py:582 in init                       │
│                                                                                                  │
│   579 │   │   │   cloud_provider, disable_prompt                                                 │
│   580 │   │   )                                                                                  │
│   581 │   │   inputs.region = check_cloud_provider_region(region, inputs.cloud_provider)         │
│ ❱ 582 │   │   inputs.kubernetes_version = check_cloud_provider_kubernetes_version(               │
│   583 │   │   │   kubernetes_version, inputs.cloud_provider, inputs.region                       │
│   584 │   │   )                                                                                  │
│   585                                                                                            │
│                                                                                                  │
│ /Users/aktech/quansight/nebari/src/_nebari/subcommands/init.py:416 in                            │
│ check_cloud_provider_kubernetes_version                                                          │
│                                                                                                  │
│   413 │   │   versions = digital_ocean.kubernetes_versions(region)                               │
│   414 │   │                                                                                      │
│   415 │   │   if not kubernetes_version or kubernetes_version == LATEST:                         │
│ ❱ 416 │   │   │   kubernetes_version = get_latest_kubernetes_version(versions)                   │
│   417 │   │   │   rich.print(                                                                    │
│   418 │   │   │   │   DEFAULT_KUBERNETES_VERSION_MSG.format(                                     │
│   419 │   │   │   │   │   kubernetes_version=kubernetes_version                                  │
│                                                                                                  │
│ /Users/aktech/quansight/nebari/src/_nebari/utils.py:299 in get_latest_kubernetes_version         │
│                                                                                                  │
│   296                                                                                            │
│   297                                                                                            │
│   298 def get_latest_kubernetes_version(versions: List[str]) -> str:                             │
│ ❱ 299 │   return sorted(versions)[-1]                                                            │
│   300                                                                                            │
│   301                                                                                            │
│   302 def construct_azure_resource_group_name(                                                   │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
IndexError: list index out of range

Versions and dependencies used.

No response

Compute environment

Digital Ocean

Integrations

No response

Anything else?

No response

@aktech aktech added type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels Mar 2, 2024
@aktech
Copy link
Member Author

aktech commented Mar 2, 2024

@marcelovilla
Copy link
Member

@aktech I'm closing this issue because it was fixed in #2276

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management May 2, 2024
@marcelovilla marcelovilla added provider: Digital Ocean area: k8s ⎈ and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants