Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - JupyterHub navbar items not redirecting correctly after visiting Admin Dashboard #2359

Closed
marcelovilla opened this issue Mar 25, 2024 · 3 comments · Fixed by #2360
Closed
Labels
type: bug 🐛 Something isn't working
Milestone

Comments

@marcelovilla
Copy link
Member

marcelovilla commented Mar 25, 2024

Describe the bug

Nebari borrows some navbar items from JupyterHub, such as the Home, Token and Admin tabs. These work fine until one goes to the Admin tab. After visiting the Admin Dashboard, trying to go back to any of the Home, Token, and even the Admin tabs result in a 404 page not found error. Here is an example of the Token tab, before and after visiting the Admin Dashboard:

Screen.Recording.2024-03-25.at.4.44.20.PM.mov

As you can see, the Token tab URL is /hub/token before visiting the Admin Dashboard, but becomes /token after that.

I can reproduce this behavior (i.e. URLs changing after visiting the Admin Dashboard; see lower left corner in the video) locally using vanilla JupyterHub, with the difference that redirection works fine:

Screen.Recording.2024-03-25.at.4.57.58.PM.mov

I guess we can have Nebari redirect /token to /hub/token but we would need to make sure that's not a general rule, as other services don't have the /hub prefix. For example: /conda-store.

Expected behavior

I would expect for users to be able to go to the Admin Dashboard and then navigate back successfully to other sections of JupyterHub (e.g., the Home or Token tabs).

OS and architecture in which you are running Nebari

AWS

How to Reproduce the problem?

  1. Visit the Admin Dashboard at /hub/admin
  2. Try to navigate to one of the Home, Token or Admin tabs.

Command output

No response

Versions and dependencies used.

Nebari 2024.3.2

Compute environment

None

Integrations

No response

Anything else?

This issue was originally identified by @kalpanachinnappan.

@dharhas
Copy link
Member

dharhas commented Mar 26, 2024

@aktech @jbouder could this be related to the UI changes y'all have been working on.

@aktech
Copy link
Member

aktech commented Mar 26, 2024

@aktech @jbouder could this be related to the UI changes y'all have been working on.

I would not expect that, since this happens without jhub-apps enabled as well. This is most likely a jupyterhub issue or maybe not exactly be an issue on JupyterHub as every url on jupyterhub is redirected to /hub/<url> by default, but in our case the ingress is most likely setup in a way to not do that redirect automatically.

@marcelovilla
Copy link
Member Author

I agree; this does not seem to have any relation to UI changes. I can reproduce the same behavior (but with proper redirection) when running JupyterHub locally.

As @aktech mentioned, a way to fix this from our end is to redirect the spawner, home, admin and token URLs and have traefik add the /hub prefix.

I'm thinking of reporting this upstream as I don't think that should be the expected behavior in JupyterHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants