Change VS Code launcher icon for the code-server icon

[marcelovilla]

Context

Currently, it seems that the only reason we're using the vscode-binder package is to add the VS Code icon to the Jupyterlab launcher:

https://github.com/nebari-dev/nebari-docker-images/blob/25697f163e296a7f03a513d0140b2b31ac109029/jupyterlab/environment.yaml#L61

If this is the only use for it, we should probably remove it and find a way of adding the code-server icon instead.

Value and/or benefit

Besides getting rid of an extra dependency, it seems there are some issues in vscode-binder for newer versions of code-server.

Anything else?

No response

[krassowski]

I'm on it as a sub-task in JupyterLab launcher redesign. I had opened betatim/vscode-binder#60 yesterday.

[viniciusdc]

@krassowski can we assign this issue to you? you seem to have a better understanding of what needs to be addressed in both places already

[viniciusdc]

@marcelovilla @krassowski the reason for the dep. being there was due to this PR #1044. The goal was to replace the installation script that we rely on for installing the code-server and use only the extension -- but we had issues with that approach (probably due to support with jupyterhub versions), and them we cycled back (there is a PR somewhere), and I guess the extension was missed

[krassowski]

Upstream PR betatim/vscode-binder#61 was merged. The icon should update next time the docker images are regenerated. There is still some follow-up work in JupyterLab because the icon currently is invisible in dark mode.

[krassowski]

Closing - in addition to upstream providing the updated icon, we are also shipping jupyterlab-new-launcher which also has the updated icon (which works better with dark mode):