Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Playwright tests are currently failing due to change in jupyter #2473

Closed
Adam-D-Lewis opened this issue May 20, 2024 · 3 comments · Fixed by #2475
Closed

[BUG] - Playwright tests are currently failing due to change in jupyter #2473

Adam-D-Lewis opened this issue May 20, 2024 · 3 comments · Fixed by #2475
Labels
type: bug 🐛 Something isn't working

Comments

@Adam-D-Lewis
Copy link
Member

Describe the bug

Fix the tests so they pass.

Expected behavior

tests should pass

OS and architecture in which you are running Nebari

Linux x86-64

How to Reproduce the problem?

See above

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

@Adam-D-Lewis Adam-D-Lewis added type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels May 20, 2024
@krassowski
Copy link
Member

For reference #2468 (comment) and nebari-dev/nebari-docker-images#146. The underlying issue is that CI does not run on PRs to docker images repo so we cannot verify changes.

@krassowski
Copy link
Member

So PR nebari-dev/nebari-docker-images#146 did resolve the problem with VS Code tile not having title attribute, but there is another issue due to the use of the new launcher:

playwright._impl._errors.Error: Locator.click: Error: strict mode violation: get_by_text("Kernel", exact=True) resolved to 3 elements:
    1) <div class="lm-MenuBar-itemLabel">Kernel</div> aka get_by_label("main menu").get_by_text("Kernel")
    2) <label>Kernel</label> aka get_by_role("cell", name="Kernel").locator("label")
    3) <label>Kernel</label> aka get_by_text("Kernel", exact=True).nth(2)

Call log:
waiting for get_by_text("Kernel", exact=True)

again, if the docker images were in monorepo, it would be caught earlier.

@Adam-D-Lewis Adam-D-Lewis removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label May 21, 2024
@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented May 21, 2024

I agree with you @krassowski that CICD needs to change to prevent issues like this. As we discussed in the meeting, someone will need to draft an RFD to move the nebari images repo back into this repo.

Thanks for working on fixing this issue!

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants