-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Playwright tests are currently failing due to change in jupyter #2473
Comments
For reference #2468 (comment) and nebari-dev/nebari-docker-images#146. The underlying issue is that CI does not run on PRs to docker images repo so we cannot verify changes. |
So PR nebari-dev/nebari-docker-images#146 did resolve the problem with VS Code tile not having
again, if the docker images were in monorepo, it would be caught earlier. |
I agree with you @krassowski that CICD needs to change to prevent issues like this. As we discussed in the meeting, someone will need to draft an RFD to move the nebari images repo back into this repo. Thanks for working on fixing this issue! |
Describe the bug
Fix the tests so they pass.
Expected behavior
tests should pass
OS and architecture in which you are running Nebari
Linux x86-64
How to Reproduce the problem?
See above
Command output
No response
Versions and dependencies used.
No response
Compute environment
None
Integrations
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: